Switch to 64-bit ints. #1357
Switch to 64-bit ints. #1357
Conversation
bruvzg
added
enhancement
AThousandShips
added
the
waiting for Godot
|
Should fix: |
AThousandShips
removed
the
waiting for Godot
There was a problem hiding this comment.
Thanks!
This looks great to me 🚀
I diff'ed the cowdata.hpp and vector.hpp from this PR with the cowdata.h and vector.h from PR godotengine/godot#86730, and they only had minor expected differences. Reading through all the rest, it all looks good.
I haven't tested it manually, but the fact that it's passing the automated tests is a very good sign.
|
I know we can merge this before Godot, however, I'm holding off on merging for a bit, just in case there's any further changes to |
|
PR godotengine/godot#86730 was just merged. I diffed the |
|
Thanks! |
|
Cherry-picking to 4.2 in #1372 |
|
Cherry-picking to 4.1 in #1373 |
|
Assuming this doesn't actually depend on the upstream changes? As they aren't cherry picked, we might want to be careful here as it does have some side effects that might be harmful: I'd hold off cherry picking this until we have worked things out |
|
It doesn't depend on upstream change, but won't fix any of the issues without them, so is not useful on its own. |
| @@ -52,6 +52,8 @@ class VMap; | |||
| template <class T> | |||
| class CharStringT; | |||
|
|
|||
| SAFE_NUMERIC_TYPE_PUN_GUARANTEES(uint64_t) | |||
There was a problem hiding this comment.
This specifically breaks on some platforms, still being investigated
Did it fix this issue btw? |
Yes it did! I've just closed that issue. |
|
Cherry-picked for 4.2 in PR #1410 |
|
Cherry-picked for 4.1 in PR #1411 |
Syncing features with godotengine/godot#86730, but since no GDExtension public API is changed, it should be compatible both ways.